Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs: readme - non ESM example - #1707

#1707
Merged
LinusU merged 1 commit into
node-fetch:mainnode-fetch/node-fetch:mainfrom
Michal-Miky-Jankovsky:mainMichal-Miky-Jankovsky/node-fetch:mainCopy head branch name to clipboard
Feb 1, 2023
Merged

docs: readme - non ESM example#1707
LinusU merged 1 commit into
node-fetch:mainnode-fetch/node-fetch:mainfrom
Michal-Miky-Jankovsky:mainMichal-Miky-Jankovsky/node-fetch:mainCopy head branch name to clipboard

Conversation

@Michal-Miky-Jankovsky

Copy link
Copy Markdown
Contributor

Purpose

Fix old example in the README.md file.

Changes

require -> import

Additional information

according to different part of the same document

node-fetch from v3 is an ESM-only module - you are not able to import it with require()

@jimmywarting jimmywarting changed the title fix: readme - non ESM example docs: readme - non ESM example Jan 30, 2023

@LinusU LinusU left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LinusU
LinusU merged commit 8ced5b9 into node-fetch:main Feb 1, 2023
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.