Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

LSP: add checker-backed local go-to-definition - #1312

#1312
Merged
nickna merged 1 commit into
mainnickna/SharpTS:mainfrom
codex/issue-1306-editor-paritynickna/SharpTS:codex/issue-1306-editor-parityCopy head branch name to clipboard
Jul 28, 2026
Merged

LSP: add checker-backed local go-to-definition#1312
nickna merged 1 commit into
mainnickna/SharpTS:mainfrom
codex/issue-1306-editor-paritynickna/SharpTS:codex/issue-1306-editor-parityCopy head branch name to clipboard

Conversation

@nickna

@nickna nickna commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • add stable semantic binding identities populated at the TypeEnvironment declaration and lookup seams
  • serve textDocument/definition for local value bindings in full language-feature mode only
  • handle hoisting, shadowing, parameters, assignments, catch/loop bindings, classes, and overload declarations
  • refuse unsafe property/member guesses until their complete semantic domain is indexed
  • preserve the existing TypeChecker APIs and document the remaining navigation work

Scope

This is the next M3 slice of #1306: local value definition. Type-namespace bindings, import/re-export provenance, cross-module definition, references, safe rename, and Track D remain for follow-up work, so the epic stays open.

Verification

  • dotnet build SharpTS.LanguageServer/SharpTS.LanguageServer.csproj --no-restore
  • dotnet test SharpTS.Tests/SharpTS.Tests.csproj --no-restore --filter FullyQualifiedName~DefinitionServiceTests (12 passed)
  • dotnet test SharpTS.Tests/SharpTS.Tests.csproj --no-restore --filter FullyQualifiedName~LanguageServer (63 passed before the final handler-only test addition)
  • dotnet test SharpTS.Tests/SharpTS.Tests.csproj --no-restore --filter FullyQualifiedName~TypeChecker (1,412 passed)
  • full suite: 16,216 passed

Refs #1306

@nickna
nickna merged commit d53bf41 into main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.