refactor(typeahead): support zoneless change detection#4920
Open
alpintar wants to merge 1 commit into
ng-bootstrap:masterng-bootstrap/ng-bootstrap:masterfrom
alpintar:zoneless-typeaheadalpintar/ng-bootstrap:zoneless-typeaheadCopy head branch name to clipboard
Open
refactor(typeahead): support zoneless change detection#4920alpintar wants to merge 1 commit intong-bootstrap:masterng-bootstrap/ng-bootstrap:masterfrom alpintar:zoneless-typeaheadalpintar/ng-bootstrap:zoneless-typeaheadCopy head branch name to clipboard
alpintar wants to merge 1 commit into
ng-bootstrap:masterng-bootstrap/ng-bootstrap:masterfrom
alpintar:zoneless-typeaheadalpintar/ng-bootstrap:zoneless-typeaheadCopy head branch name to clipboard
Conversation
Run the typeahead specs under the zoneless test setup and make the directive work without Zone.js, keeping the public API unchanged. Also added a new test case verifying that the zoneless change detection works where it was previously broken.
alpintar
force-pushed
the
zoneless-typeahead
branch
from
July 23, 2026 07:33
b7a951b to
fcb281a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the typeahead specs under the zoneless test setup and make the directive work without Zone.js, keeping the public API unchanged. Also added a new test case verifying that the zoneless change detection works where it was previously broken (aria attribute activedescendant was stale and needed markForCheck() call).
The change does not affect the public API of a typeahead component and does not alter the behaviour.
ref #4879