refactor(log): simplify and optimize log level evaluation#62468
Draft
joshtrichards wants to merge 2 commits into
masternextcloud/server:masterfrom
jtr/refactor-log-getLogLevelnextcloud/server:jtr/refactor-log-getLogLevelCopy head branch name to clipboard
Draft
refactor(log): simplify and optimize log level evaluation#62468joshtrichards wants to merge 2 commits intomasternextcloud/server:masterfrom jtr/refactor-log-getLogLevelnextcloud/server:jtr/refactor-log-getLogLevelCopy head branch name to clipboard
joshtrichards wants to merge 2 commits into
masternextcloud/server:masterfrom
jtr/refactor-log-getLogLevelnextcloud/server:jtr/refactor-log-getLogLevelCopy head branch name to clipboard
Conversation
Extract log-condition evaluation from getLogLevel() and defer user-session lookup until a matching rule requires it. Signed-off-by: Josh <josh.t.richards@gmail.com>
Add coverage for skipping unnecessary user lookups and preserving first-match precedence for configured log conditions. Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid unnecessary user-session lookups for log-condition rules rejected by app or message filters, and improve the readability and maintainability of log-level evaluation.
Changes:
getLogLevel()Log-level selection behavior remains unchanged.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)