Closed
SCHED-2200: Bump golangci-lint to v2.12.2#2783
Conversation
The lint job runs via pull_request_target, so the workflow definition comes from the base branch. Bumping the pin while the module still targets Go 1.25 lets the Go 1.26 migration PR lint with a linter that supports it. Fix govet inline-analyzer findings the new version reports: reflect.Ptr -> reflect.Pointer, constraints.Ordered -> cmp.Ordered, x/exp/slices -> stdlib slices.
Bump the go directive to 1.26.0 and golang base images to 1.26. Switch gomodguard to gomodguard_v2 in the linter config. golang.org/x/exp becomes an indirect dependency and mockery output picks up go1.26 formatting.
theyoprst
force-pushed
the
SCHED-2200/0
branch
2 times, most recently
from
July 24, 2026 15:56
b4c12cf to
0ccefca
Compare
Collaborator
Author
|
Replaced by a re-stacked PR: GitHub's stack feature does not allow changing the base branch, and this PR needs to sit on top of #2788 (golangci-lint bump) rather than main. Same branch, same content; see the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Go 1.26 migration (#2784) cannot pass lint while main pins golangci-lint v2.5.0: the lint job runs on
pull_request_target, so the workflow definition comes from the PR base branch, and v2.5.0 is built with go1.25 and refuses go 1.26 modules.Solution
reflect.Ptr->reflect.Pointer,constraints.Ordered->cmp.Ordered,x/exp/slices-> stdlibslices#2784 is stacked on this branch, so its lint runs with v2.12.2.
Testing
Linted with v2.5.0 (what this PR's own CI runs) and v2.12.2 (what main runs after merge): 0 issues both. Unit suite green.
Release Notes
None