Rebase of #76: boost headers test variant#80
Open
TallJimbo wants to merge 4 commits into
masterndarray/ndarray:masterfrom
boost_headers_test_variantndarray/ndarray:boost_headers_test_variantCopy head branch name to clipboard
Open
Rebase of #76: boost headers test variant#80TallJimbo wants to merge 4 commits intomasterndarray/ndarray:masterfrom boost_headers_test_variantndarray/ndarray:boost_headers_test_variantCopy head branch name to clipboard
TallJimbo wants to merge 4 commits into
masterndarray/ndarray:masterfrom
boost_headers_test_variantndarray/ndarray:boost_headers_test_variantCopy head branch name to clipboard
Conversation
Member
Author
|
@brianv0, this is now failing with linker errors on the unit tests, so I think I'm going to put this back in your court to debug. I have no idea why it succeeded once on your previous PR but is failing now, unless it's something that changed in the conda packages in the past week. One way around this might be to just switch from Boost.Test to https://github.com/catchorg/, which can just be dropped into the repo directly as a single-header library. That seems like the right approach long-term, but I can't promise I'll get to it any time soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.