fix: enforce strict_map_key with object_pairs_hook#673
Merged
methane merged 2 commits intoMay 12, 2026
msgpack:mainmsgpack/msgpack-python:mainfrom
KowalskiThomas:kowalski/fix-enforce-strict_map_key-with-object_pairs_hookKowalskiThomas/msgpack-python:kowalski/fix-enforce-strict_map_key-with-object_pairs_hookCopy head branch name to clipboard
Merged
fix: enforce strict_map_key with object_pairs_hook#673methane merged 2 commits intomsgpack:mainmsgpack/msgpack-python:mainfrom KowalskiThomas:kowalski/fix-enforce-strict_map_key-with-object_pairs_hookKowalskiThomas/msgpack-python:kowalski/fix-enforce-strict_map_key-with-object_pairs_hookCopy head branch name to clipboard
strict_map_key with object_pairs_hook#673methane merged 2 commits into
msgpack:mainmsgpack/msgpack-python:mainfrom
KowalskiThomas:kowalski/fix-enforce-strict_map_key-with-object_pairs_hookKowalskiThomas/msgpack-python:kowalski/fix-enforce-strict_map_key-with-object_pairs_hookCopy head branch name to clipboard
Conversation
4e04c8c to
e24d5de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR makes it so that
self._strict_map_keyis enforced even when using_object_pairs_hookwhich didn't use to be the case.