Modern build fixes and buffer overrun fixes#376
Open
dpw13 wants to merge 5 commits into
Open
Modern build fixes and buffer overrun fixes#376dpw13 wants to merge 5 commits into
dpw13 wants to merge 5 commits into
Conversation
I've attempted to match the existing formatting as closely as possible, but as some of the formatting is internally inconsistent, there are a number of changes that unfortunately will make git blame a bit confusing. There are a few options here I don't think improve things like AllowShortBlocksOnASingleLine causing a few more complex statements to be collapsed onto a single line, but overall this change should unify the code without too much confusion. As a manual step I've also trimmed all trailing spaces in .h and .c files as apparently clang-format only does this for lines it modifies.
dpw13
force-pushed
the
dev/dwagner-build
branch
from
October 19, 2025 19:04
6789b42 to
857a29f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates mp3splt to build with modern versions of gcc and fixes a number of buffer overrun vulnerabilities. It also introduces clang-format for standardizing the formatting for code across the repo, which will hopefully reduce the number of style changes present in future PRs.
This PR is more informational than an earnest request to merge, as I'm adding some functionality to mp3splt and want to ensure my changes are visible in some way from the original repo. However if anyone is interested in merging and has concerns, I will be happy to address them to maintain a single repo.