[Pipelines] Handle missing custom ARCHITECTURES list - #6778
#6778Draft
mattfaltyn wants to merge 1 commit into
modular:mainmodular/modular:mainfrom
mattfaltyn:agent/handle-missing-custom-architecturesmattfaltyn/modular:agent/handle-missing-custom-architecturesCopy head branch name to clipboard
Draft
[Pipelines] Handle missing custom ARCHITECTURES list#6778mattfaltyn wants to merge 1 commit intomodular:mainmodular/modular:mainfrom mattfaltyn:agent/handle-missing-custom-architecturesmattfaltyn/modular:agent/handle-missing-custom-architecturesCopy head branch name to clipboard
mattfaltyn wants to merge 1 commit into
modular:mainmodular/modular:mainfrom
mattfaltyn:agent/handle-missing-custom-architecturesmattfaltyn/modular:agent/handle-missing-custom-architecturesCopy head branch name to clipboard
Conversation
mattfaltyn
force-pushed
the
agent/handle-missing-custom-architectures
branch
from
July 15, 2026 08:35
628c91d to
8cbb3e1
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
All contributors have signed the CLA ✍️ ✅ |
mattfaltyn
force-pushed
the
agent/handle-missing-custom-architectures
branch
2 times, most recently
from
July 15, 2026 10:07
9a87782 to
ba16074
Compare
BEGIN_PUBLIC [Pipelines] Handle missing custom ARCHITECTURES list Return the intended actionable error when a custom architecture module omits its required ARCHITECTURES list, and cover the failure with a focused regression test. END_PUBLIC Assisted-by: AI Signed-off-by: Matt Faltyn <faltyn.matthew@gmail.com>
mattfaltyn
force-pushed
the
agent/handle-missing-custom-architectures
branch
from
July 15, 2026 10:20
ba16074 to
a1a89be
Compare
Author
|
The current Build/Test failure appears unrelated to this PR. The only failing target is I attempted to rerun the failed job, but GitHub requires repository admin rights, so a maintainer will need to rerun the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Fixes #6777
Type of change
Motivation
Custom architecture modules that import successfully but omit the required
ARCHITECTURESlist currently raise a rawAttributeError. This bypasses theactionable
ValueErroralready intended by the loader's validation branch.What changed
ARCHITECTURESonce withgetattr()before validating it.ARCHITECTURES.Testing
./bazelw run formatpassed and made no changes.ruff check max/python/max/pipelines/lib/registry.py max/tests/tests/pipelines/lib/test_registry.pyruff format --check max/python/max/pipelines/lib/registry.py max/tests/tests/pipelines/lib/test_registry.pymax/tests/tests/pipelines/libpackage: 215 passedwith 5 existing collection warnings.
./bazelw test //max/tests/tests/pipelines/... //max/tests/integration/pipelines:testsbuilt successfully: 5 tests passed and 32 macOS-incompatible tests were
skipped.
Checklist
agreed-upon, or this is a trivial fix that does not need prior approval
./bazelw run formatto format my changesAssisted-by:trailer in my commit message or this PR descriptionAssisted-by: AI