[RDNA] Add W4A16 quantized kernel path for RDNA3 - #6736
#6736Draft
big-yellow-duck wants to merge 3 commits into
modular:mainmodular/modular:mainfrom
big-yellow-duck:rdna3-quantized-modelbig-yellow-duck/modular:rdna3-quantized-modelCopy head branch name to clipboard
Draft
[RDNA] Add W4A16 quantized kernel path for RDNA3#6736big-yellow-duck wants to merge 3 commits intomodular:mainmodular/modular:mainfrom big-yellow-duck:rdna3-quantized-modelbig-yellow-duck/modular:rdna3-quantized-modelCopy head branch name to clipboard
big-yellow-duck wants to merge 3 commits into
modular:mainmodular/modular:mainfrom
big-yellow-duck:rdna3-quantized-modelbig-yellow-duck/modular:rdna3-quantized-modelCopy head branch name to clipboard
Conversation
Author
|
this currently has issues with batch_size>1 Imma chec then comeback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
None
Type of change
Motivation
This PR adds a W4A16 quantized matmul path intended to let GPTQ/int4 Llama-style models run on RDNA3 GPUs through MAX.
The specific local validation target is
hugging-quants/Meta-Llama-3.1-8B-Instruct-GPTQ-INT4on rdna3/3.5. Without the RDNA3 W4A16 execution path, RDNA gpus cannot serve quantized gptq/awq models .What changed
Testing
Validated locally on branch
rdna3-quantized-model:This built successfully and printed the
serveCLI help.Then launched MAX serve with:
Confirmed
/v1/modelsreturned the expected model ID andmax_model_len: 131072.Sent two OpenAI-compatible chat completion smoke tests:
What is 17 plus 25?returnedThe sum of 17 and 25 is 42.finish_reason: "length"only because the smoke test cappedmax_tokensat 80Not yet run:
Checklist
./bazelw run formatto format my changesAssisted-by:trailer in my commit message or this PR descriptionAI assistance disclosure
Assisted-by: Codex