-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Feature/add enable disable methods tools #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davila7
wants to merge
8
commits into
modelcontextprotocol:main
Choose a base branch
from
davila7:feature/add-enable-disable-methods-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−3
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
04207c4
Add tool enable/disable functionality with client notifications
davila7 086cc54
add enable and disable tool functionality to README
davila7 213b1c3
Fix spaces in README.md
davila7 1e4f570
Merge branch 'modelcontextprotocol:main' into feature/add-enable-disa…
davila7 fd71115
fix function disable_tool and enable_tool. Pytest executed successfully
davila7 c5ed1f7
Merge branch 'main' into feature/add-enable-disable-methods-tools
davila7 1ae4467
Merge branch 'main' into feature/add-enable-disable-methods-tools
davila7 7b32590
Merge branch 'main' into feature/add-enable-disable-methods-tools
davila7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add similar checks in call_tool() and get_tool() as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For call_tool() we already have the necessary validation checking if the tool is enabled.
And for get_tool(), I think we don't need to add this validation. We retrieve in get_tool() and validate in call_tool() where the tool is actually used.
This keeps the code cleaner and lets us access disabled tools when needed (for inspection, etc).