Feature/add enable disable methods tools #728
Open
+97
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble-methods-tools
bzsurbhi
reviewed
May 20, 2025
| @@ -72,4 +72,7 @@ async def call_tool( | ||
| if not tool: | ||
| raise ToolError(f"Unknown tool: {name}") | ||
|
|
||
| if not tool.enabled: |
There was a problem hiding this comment.
Should we add similar checks in call_tool() and get_tool() as well?
There was a problem hiding this comment.
For call_tool() we already have the necessary validation checking if the tool is enabled.
And for get_tool(), I think we don't need to add this validation. We retrieve in get_tool() and validate in call_tool() where the tool is actually used.
This keeps the code cleaner and lets us access disabled tools when needed (for inspection, etc).
bzsurbhi
reviewed
May 20, 2025
I've added it to the README in this commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to dynamically enable and disable tools at runtime with client notifications.
Motivation and Context
This change allows developers to temporarily restrict access to specific tools without removing them from the tool manager. This is useful for implementing feature flags, managing resource availability, or controlling access to functionality based on runtime conditions.
How Has This Been Tested?
Breaking Changes
The tool list now includes the enabled state of each tool. However, all tools are initialized with enabled=True by default, maintaining backward compatibility with existing code.
Types of changes
Checklist