Gracefully fail if Network and IPAM plugins are used#1856
Merged
aaronlehmann merged 1 commit intomoby:mastermoby/swarmkit:masterfrom Jan 11, 2017
Merged
Gracefully fail if Network and IPAM plugins are used#1856aaronlehmann merged 1 commit intomoby:mastermoby/swarmkit:masterfrom
aaronlehmann merged 1 commit intomoby:mastermoby/swarmkit:masterfrom
Conversation
Due to multiple issues in both plugin-v1 and plugin-v2 support, we decided to gracefully fail the network create if either network or ipam plugin is used. Signed-off-by: Madhu Venugopal <madhu@docker.com>
Current coverage is 54.64% (diff: 60.00%)@@ master #1856 diff @@
==========================================
Files 103 103
Lines 17248 17250 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 9419 9426 +7
+ Misses 6689 6682 -7
- Partials 1140 1142 +2
|
Collaborator
|
LGTM |
This was referenced Jan 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to multiple issues in both plugin-v1 and plugin-v2 support,
this patch will disable the network plugin support by gracefully
failing the network create if either network or ipam plugin is used. 😢
We will revisit the support once the plugin issues are resolved.
Signed-off-by: Madhu Venugopal madhu@docker.com