Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[1.13] Update vendored swarmkit to 296fcfc#30042

Merged
mavenugo merged 2 commits intomoby:1.13.xmoby/moby:1.13.xfrom
aaronlehmann:vendor-swarmkit-296fcfcaaronlehmann/docker:vendor-swarmkit-296fcfcCopy head branch name to clipboard
Jan 11, 2017
Merged

[1.13] Update vendored swarmkit to 296fcfc#30042
mavenugo merged 2 commits intomoby:1.13.xmoby/moby:1.13.xfrom
aaronlehmann:vendor-swarmkit-296fcfcaaronlehmann/docker:vendor-swarmkit-296fcfcCopy head branch name to clipboard

Conversation

@aaronlehmann
Copy link
Copy Markdown

Update vendored swarmkit to 296fcfc

This brings in the following change, disabling network plugins in swarm mode:

cc @mavenugo

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@stevvooe
Copy link
Copy Markdown
Contributor

LGTM

@mavenugo
Copy link
Copy Markdown
Contributor

LGTM 😢

@anusha-ragunathan I think we should discuss with @aaronlehmann to bring in native plugin-v2 support for networking into swarmkit asap. That will enable network plugin providers to provide proper swarm-mode support.

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Jan 11, 2017

LGTM

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Jan 11, 2017

@aaronlehmann unused variable in tests

@thaJeztah thaJeztah added this to the 1.13.0 milestone Jan 11, 2017
Signed-off-by: Madhu Venugopal <madhu@docker.com>
@aaronlehmann aaronlehmann force-pushed the vendor-swarmkit-296fcfc branch from e9fb4fb to c8083e8 Compare January 11, 2017 00:38
@mavenugo mavenugo merged commit e0c07ab into moby:1.13.x Jan 11, 2017
@aaronlehmann aaronlehmann deleted the vendor-swarmkit-296fcfc branch January 11, 2017 05:27
@justintime4tea
Copy link
Copy Markdown

How would one go about updating the vendored swarmkit themselves? I've made changes to the spec.proto and need to regenerate protobufs.

@stevvooe
Copy link
Copy Markdown
Contributor

@justintime4tea VENDORING.md provides details on how to update dependencies. Let me know if that helps.

In the future, please avoid hijacking issues with unrelated questions. Either use the forums, slack stack overflow or other communications means to ask questions and we'll try to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.