Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: propagate registry auth error in swarm image pull#52698

Merged
vvoland merged 1 commit into
moby:mastermoby/moby:masterfrom
MD-Mushfiqur123:fix/issue-52570-swarm-auth-errorMD-Mushfiqur123/moby:fix/issue-52570-swarm-auth-errorCopy head branch name to clipboard
Jun 12, 2026
Merged

fix: propagate registry auth error in swarm image pull#52698
vvoland merged 1 commit into
moby:mastermoby/moby:masterfrom
MD-Mushfiqur123:fix/issue-52570-swarm-auth-errorMD-Mushfiqur123/moby:fix/issue-52570-swarm-auth-errorCopy head branch name to clipboard

Conversation

@MD-Mushfiqur123

@MD-Mushfiqur123 MD-Mushfiqur123 commented May 25, 2026 •
edited by vvoland
Loading

Copy link
Copy Markdown

Fixes #52570

When a worker pull fails with 'unauthorized: authentication required',
the error was being swallowed and replaced with a misleading
'No such image' message. This fix ensures the actual registry error
is propagated so operators see the real cause.

Fix a bug where registry authentication failures during worker image pulls were reported as a misleading “No such image” error.

@vvoland

vvoland commented May 25, 2026

Copy link
Copy Markdown
Contributor

Hi, please sign-off the commit with your real name: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work

@vvoland
vvoland requested a review from corhere May 25, 2026 11:42
@MD-Mushfiqur123

MD-Mushfiqur123 commented May 27, 2026

Copy link
Copy Markdown
Author

Friendly ping — this PR is ready for review. All CI checks are passing.

@MD-Mushfiqur123
MD-Mushfiqur123 force-pushed the fix/issue-52570-swarm-auth-error branch from 3921dc9 to 5f42ea8 Compare May 27, 2026 07:12
@vvoland

vvoland commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Oh, could you please also remove the Fixes #... from the commit message? Unfortunately Github makes this too noisy

@vvoland vvoland added this to the 29.5.3 milestone May 27, 2026
@vvoland vvoland modified the milestones: 29.5.3, 29.6.0 Jun 3, 2026
@vvoland

vvoland commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@md-mushfiqur-rahim123-official can you please update?

@md-mushfiqur-rahim123-official @thaJeztah
fix: propagate registry auth error in swarm image pull
a7cf7ea 
When a worker pull fails with unauthorized, the error was being
swallowed and replaced with misleading 'No such image' message.
Fix error propagation so the actual cause is reported.

Signed-off-by: Md_Mushfiqur Rahim <20mahin20201@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah force-pushed the fix/issue-52570-swarm-auth-error branch from 5f42ea8 to a7cf7ea Compare June 12, 2026 13:38
thaJeztah
thaJeztah approved these changes Jun 12, 2026
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(rebased and adjusted the commit message)

@thaJeztah

thaJeztah commented Jun 12, 2026

Copy link
Copy Markdown
Member

Flaky tests on Windows;

=== Failed
=== FAIL: integration/container TestWaitNonBlocked/wait-nonblocking-exit-0 (33.42s)
    wait_test.go:46: timeout hit after 30s: waiting for container State.Status to be 'exited', currently 'running'

=== FAIL: integration/container TestWaitNonBlocked (0.26s)

=== Failed
=== FAIL: integration-cli TestDockerAPISuite/TestContainersAPICreateMountsCreate/4_config:_{volume_test3_c:\foo_false__<nil>_0x2a70b07b5dd0_<nil>_<nil>_<nil>} (12.81s)
    docker_api_containers_test.go:1667: timeout hit after 10s: container b8d2bb18674dca58cea1ef7c39b985d729437779e7de43f7945b87c1c1ff22c1 is running, waiting for exit

=== FAIL: integration-cli TestDockerAPISuite/TestContainersAPICreateMountsCreate (50.09s)

@vvoland
vvoland merged commit a8029f6 into moby:master Jun 12, 2026
411 of 418 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes
@corhere corhere Awaiting requested review from corhere

Assignees

No one assigned

Labels

area/daemon Core Engine area/swarm impact/changelog kind/bugfix PR's that fix bugs status/4-merge

Projects

None yet

Milestone

29.6.0

Development

Successfully merging this pull request may close these issues.

swarm task error reports misleading "No such image" when the actual cause is unauthorized: authentication required

5 participants

@MD-Mushfiqur123 @vvoland @thaJeztah @thompson-shaun @md-mushfiqur-rahim123-official
Morty Proxy This is a proxified and sanitized view of the page, visit original site.