NRI: error on unsupported adjustment#51712
Merged
robmry merged 1 commit intoDec 15, 2025
moby:mastermoby/moby:masterfrom
robmry:nri-error-on-unsupported-adjustmentrobmry/moby:nri-error-on-unsupported-adjustmentCopy head branch name to clipboard
Merged
NRI: error on unsupported adjustment#51712robmry merged 1 commit intomoby:mastermoby/moby:masterfrom robmry:nri-error-on-unsupported-adjustmentrobmry/moby:nri-error-on-unsupported-adjustmentCopy head branch name to clipboard
robmry merged 1 commit into
moby:mastermoby/moby:masterfrom
robmry:nri-error-on-unsupported-adjustmentrobmry/moby:nri-error-on-unsupported-adjustmentCopy head branch name to clipboard
Conversation
robmry
marked this pull request as draft
December 12, 2025 17:42
robmry
force-pushed
the
nri-error-on-unsupported-adjustment
branch
3 times, most recently
from
December 15, 2025 09:42
e6e8aaf to
9066c4b
Compare
robmry
marked this pull request as ready for review
December 15, 2025 09:46
vvoland
approved these changes
Dec 15, 2025
austinvazquez
approved these changes
Dec 15, 2025
austinvazquez
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just had a quick question on one part of the check unsupported adjustments function.
Also error on eviction requests. Signed-off-by: Rob Murray <rob.murray@docker.com>
robmry
force-pushed
the
nri-error-on-unsupported-adjustment
branch
from
December 15, 2025 14:08
9066c4b to
98d196b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Return an error if NRI tries to make an update we don't support yet.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)