daemon: Daemon.stats: fill-in container ID and Name when collecting#51302
Merged
Merged
daemon: Daemon.stats: fill-in container ID and Name when collecting#51302
Conversation
1 task
Propagate these fields when collecting the data, instead of patching the
result inside the router.
This also fixes a bug where the ID and Name fields were not set when using
one-shot.
Before this patch, the "id" and "name" fields were not set in one-shot mode:
curl -s --unix-socket /var/run/docker.sock 'http://localhost/v1.51/containers/foo/stats?stream=false' | jq .id
"125d7f3df7919c33195fa4ec0636c27cdbe6d9b14339867d2920900565bcaf7e"
curl -s --unix-socket /var/run/docker.sock 'http://localhost/v1.51/containers/foo/stats?stream=false' | jq .name
"/foo"
curl -s --unix-socket /var/run/docker.sock 'http://localhost/v1.51/containers/foo/stats?stream=false&one-shot=true' | jq .id
null
curl -s --unix-socket /var/run/docker.sock 'http://localhost/v1.51/containers/foo/stats?stream=false&one-shot=true' | jq .name
null
With this patch, both are set:
curl -s --unix-socket /var/run/docker.sock 'http://localhost/v1.51/containers/foo/stats?stream=false&one-shot=true' | jq .id
"125d7f3df7919c33195fa4ec0636c27cdbe6d9b14339867d2920900565bcaf7e"
curl -s --unix-socket /var/run/docker.sock 'http://localhost/v1.51/containers/foo/stats?stream=false&one-shot=true' | jq .name
"/foo"
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_one_shot_stats
branch
from
October 27, 2025 09:55
c93dbb4 to
e410daf
Compare
This was referenced Oct 27, 2025
robmry
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate these fields when collecting the data, instead of patching the result inside the router.
This also fixes a bug where the ID and Name fields were not set when using one-shot.
Before this patch, the "id" and "name" fields were not set in one-shot mode:
With this patch, both are set:
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)