Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

client: rewrite prune functions to use option structs and result#51200

Merged
thaJeztah merged 4 commits into
moby:mastermoby/moby:masterfrom
thaJeztah:prune_option_structsthaJeztah/docker:prune_option_structsCopy head branch name to clipboard
Oct 16, 2025
Merged

client: rewrite prune functions to use option structs and result#51200
thaJeztah merged 4 commits into
moby:mastermoby/moby:masterfrom
thaJeztah:prune_option_structsthaJeztah/docker:prune_option_structsCopy head branch name to clipboard

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Oct 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

client: rewrite prune functions to use option structs and result

  • client: ContainersPrune: rewrite to use option structs and result
  • client: ImagesPrune: rewrite to use option structs and result
  • client: NetworksPrune: rewrite to use option structs and result
  • client: VolumesPrune: rewrite to use option structs and result

- Human readable description for the release notes

client: ContainersPrune: rewrite to use option structs and result
client: ImagesPrune: rewrite to use option structs and result
client: NetworksPrune: rewrite to use option structs and result
client: VolumesPrune: rewrite to use option structs and result

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
client: ContainersPrune: rewrite to use option structs and result
91323b7 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
client: ImagesPrune: rewrite to use option structs and result
0672a0f 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
client: NetworksPrune: rewrite to use option structs and result
b11d9d4 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
client: VolumesPrune: rewrite to use option structs and result
865cfe9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 16, 2025
@thaJeztah thaJeztah added status/2-code-review impact/changelog kind/refactor PR's that refactor, or clean-up code area/go-sdk impact/go-sdk Noteworthy (compatibility changes) in the Go SDK release-blocker PRs we want to block a release on module/client labels Oct 16, 2025
@thaJeztah thaJeztah mentioned this pull request Oct 16, 2025
Closed
@thaJeztah
thaJeztah marked this pull request as ready for review October 16, 2025 11:48
@thaJeztah
thaJeztah requested review from robmry and vvoland October 16, 2025 11:59
akerouanton
akerouanton approved these changes Oct 16, 2025
View reviewed changes

@akerouanton akerouanton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question but nothing harmful. LGTM

Comment thread integration/image/prune_test.go
defer d.Stop(t)

apiClient := d.NewClientT(t)
defer apiClient.Close()

@akerouanton akerouanton Oct 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop these?

@thaJeztah thaJeztah Oct 16, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! Right, my IDE kept being noisy about unhandled errors, and in this case NewClientT already handles closing;

moby/internal/testutil/daemon/daemon.go

Lines 295 to 302 in b514589

func (d *Daemon) NewClientT(t testing.TB, extraOpts ...client.Opt) *client.Client {
t.Helper()
c, err := d.NewClient(extraOpts...)
assert.NilError(t, err, "[%s] could not create daemon client", d.id)
t.Cleanup(func() { c.Close() })
return c
}

@thaJeztah
thaJeztah merged commit f6e52c8 into moby:master Oct 16, 2025
205 of 206 checks passed
@thaJeztah
thaJeztah deleted the prune_option_structs branch October 16, 2025 13:20
@thaJeztah thaJeztah mentioned this pull request Oct 17, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akerouanton akerouanton akerouanton approved these changes
@robmry robmry robmry approved these changes
@vvoland vvoland Awaiting requested review from vvoland

Assignees

No one assigned

Labels

area/dependencies area/go-sdk area/images Image Service area/volumes Volumes impact/changelog impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code module/client release-blocker PRs we want to block a release on status/2-code-review

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @akerouanton @robmry
Morty Proxy This is a proxified and sanitized view of the page, visit original site.