api/types/swarm: remove deprecated ServiceSpec.Networks field#51184
Merged
thaJeztah merged 1 commit intoOct 20, 2025
moby:mastermoby/moby:masterfrom
thaJeztah:remove_servicespec_networksthaJeztah/docker:remove_servicespec_networksCopy head branch name to clipboard
Merged
api/types/swarm: remove deprecated ServiceSpec.Networks field#51184thaJeztah merged 1 commit intomoby:mastermoby/moby:masterfrom thaJeztah:remove_servicespec_networksthaJeztah/docker:remove_servicespec_networksCopy head branch name to clipboard
thaJeztah merged 1 commit into
moby:mastermoby/moby:masterfrom
thaJeztah:remove_servicespec_networksthaJeztah/docker:remove_servicespec_networksCopy head branch name to clipboard
Conversation
thaJeztah
force-pushed
the
remove_servicespec_networks
branch
from
October 14, 2025 12:56
8c6bff9 to
fa42e21
Compare
thaJeztah
force-pushed
the
remove_servicespec_networks
branch
from
October 14, 2025 13:15
fa42e21 to
0df94a7
Compare
Member
Author
|
Looks like |
Member
Author
thaJeztah
force-pushed
the
remove_servicespec_networks
branch
2 times, most recently
from
October 17, 2025 12:53
2ee8784 to
88a4607
Compare
Member
Author
|
Nice! Looks like my PR works; 
|
This field was deprecated in [engine-api@5c4b684], which got vendored into Moby in [moby/moby@8f7a8c7] (API v1.25), and wired up in [moby/moby@99a98cc]. [engine-api@5c4b684]: docker-archive-public/docker.engine-api@5c4b684 [moby/moby@8f7a8c7]: moby@8f7a8c7 [moby/moby@99a98cc]: moby@99a98cc Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_servicespec_networks
branch
from
October 17, 2025 20:20
88a4607 to
5061d0a
Compare
thaJeztah
marked this pull request as ready for review
October 17, 2025 23:57
thaJeztah
commented
Oct 20, 2025
Comment on lines
+175
to
+181
| if versions.LessThan(cliVersion, "1.25") { | ||
| legacyResponse := make([]*compat.Wrapper, 0, len(services)) | ||
| for _, s := range services { | ||
| legacyResponse = append(legacyResponse, backFillLegacyNetwork(s)) | ||
| } | ||
| return httputils.WriteJSON(w, http.StatusOK, legacyResponse) | ||
| } |
Member
Author
There was a problem hiding this comment.
FWIW, I opened this PR before we disabled API < v1.44 by default, but probably won't do harm to keep these for now, and we can rip them out once we fully drop those API versions.
robmry
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
api/types/swarm: remove deprecated ServiceSpec.Networks field
This field was deprecated in engine-api@5c4b684, which got vendored into Moby in moby@8f7a8c7 (API v1.25), and wired up in moby@99a98cc.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)