api: info: omit deprecated "Commit.Expected" fields on API >= 1.49#48556
Merged
thaJeztah merged 1 commit intoApr 10, 2025
moby:mastermoby/moby:masterfrom
thaJeztah:deprecate_info_expected_version_step2thaJeztah/docker:deprecate_info_expected_version_step2Copy head branch name to clipboard
Merged
api: info: omit deprecated "Commit.Expected" fields on API >= 1.49#48556thaJeztah merged 1 commit intomoby:mastermoby/moby:masterfrom thaJeztah:deprecate_info_expected_version_step2thaJeztah/docker:deprecate_info_expected_version_step2Copy head branch name to clipboard
thaJeztah merged 1 commit into
moby:mastermoby/moby:masterfrom
thaJeztah:deprecate_info_expected_version_step2thaJeztah/docker:deprecate_info_expected_version_step2Copy head branch name to clipboard
Conversation
thaJeztah
force-pushed
the
deprecate_info_expected_version_step2
branch
from
September 27, 2024 07:16
38c5299 to
099619e
Compare
thaJeztah
force-pushed
the
deprecate_info_expected_version_step2
branch
from
September 30, 2024 17:06
099619e to
1cfb492
Compare
tianon
reviewed
Oct 8, 2024
Comment on lines
+32
to
+34
| // FIXME(theJeztah): this should be API 1.49 | ||
| t.Run("1.47", func(t *testing.T) { | ||
| apiClient, err := client.NewClientWithOpts(client.FromEnv, client.WithVersion("1.47")) |
Member
There was a problem hiding this comment.
Did you mean "this should be API 1.48" here? (1.49 minus one)
thaJeztah
force-pushed
the
deprecate_info_expected_version_step2
branch
from
January 6, 2025 13:50
1cfb492 to
60092da
Compare
thaJeztah
force-pushed
the
deprecate_info_expected_version_step2
branch
from
April 5, 2025 10:34
60092da to
cc309b9
Compare
thaJeztah
marked this pull request as ready for review
April 5, 2025 10:36
thaJeztah
force-pushed
the
deprecate_info_expected_version_step2
branch
from
April 7, 2025 17:13
cc309b9 to
b8ad0a9
Compare
These fields were deprecated in ff191c5, and are now omitted. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_info_expected_version_step2
branch
from
April 8, 2025 13:16
b8ad0a9 to
564abf9
Compare
Member
Author
vvoland
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)