Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[23.0] update go to go1.19.8#45277

Merged
thaJeztah merged 1 commit into
moby:23.0moby/moby:23.0from
thaJeztah:23.0_bump_go1.19.8thaJeztah/docker:23.0_bump_go1.19.8Copy head branch name to clipboard
Apr 5, 2023
Merged

[23.0] update go to go1.19.8#45277
thaJeztah merged 1 commit into
moby:23.0moby/moby:23.0from
thaJeztah:23.0_bump_go1.19.8thaJeztah/docker:23.0_bump_go1.19.8Copy head branch name to clipboard

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

go1.19.8 (released 2023-04-04) includes security fixes to the go/parser, html/template, mime/multipart, net/http, and net/textproto packages, as well as bug fixes to the linker, the runtime, and the time package. See the Go 1.19.8 milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.19.8+label%3ACherryPickApproved

full diff: golang/go@go1.19.7...go1.19.8

Further details from the announcement on the mailing list:

We have just released Go versions 1.20.3 and 1.19.8, minor point releases. These minor releases include 4 security fixes following the security policy:

  • go/parser: infinite loop in parsing

    Calling any of the Parse functions on Go source code which contains //line
    directives with very large line numbers can cause an infinite loop due to
    integer overflow.
    Thanks to Philippe Antoine (Catena cyber) for reporting this issue.
    This is CVE-2023-24537 and Go issue https://go.dev/issue/59180.

  • html/template: backticks not treated as string delimiters

    Templates did not properly consider backticks (`) as Javascript string
    delimiters, and as such did not escape them as expected. Backticks are
    used, since ES6, for JS template literals. If a template contained a Go
    template action within a Javascript template literal, the contents of the
    action could be used to terminate the literal, injecting arbitrary Javascript
    code into the Go template.

    As ES6 template literals are rather complex, and themselves can do string
    interpolation, we've decided to simply disallow Go template actions from being
    used inside of them (e.g. "var a = {{.}}"), since there is no obviously safe
    way to allow this behavior. This takes the same approach as
    github.com/google/safehtml. Template.Parse will now return an Error when it
    encounters templates like this, with a currently unexported ErrorCode with a
    value of 12. This ErrorCode will be exported in the next major release.

    Users who rely on this behavior can re-enable it using the GODEBUG flag
    jstmpllitinterp=1, with the caveat that backticks will now be escaped. This
    should be used with caution.

    Thanks to Sohom Datta, Manipal Institute of Technology, for reporting this issue.

    This is CVE-2023-24538 and Go issue https://go.dev/issue/59234.

  • net/http, net/textproto: denial of service from excessive memory allocation

    HTTP and MIME header parsing could allocate large amounts of memory, even when
    parsing small inputs.

    Certain unusual patterns of input data could cause the common function used to
    parse HTTP and MIME headers to allocate substantially more memory than
    required to hold the parsed headers. An attacker can exploit this behavior to
    cause an HTTP server to allocate large amounts of memory from a small request,
    potentially leading to memory exhaustion and a denial of service.
    Header parsing now correctly allocates only the memory required to hold parsed
    headers.

    Thanks to Jakob Ackermann (@das7pad) for discovering this issue.

    This is CVE-2023-24534 and Go issue https://go.dev/issue/58975.

  • net/http, net/textproto, mime/multipart: denial of service from excessive resource consumption

    Multipart form parsing can consume large amounts of CPU and memory when
    processing form inputs containing very large numbers of parts. This stems from
    several causes:

    mime/multipart.Reader.ReadForm limits the total memory a parsed multipart form
    can consume. ReadForm could undercount the amount of memory consumed, leading
    it to accept larger inputs than intended. Limiting total memory does not
    account for increased pressure on the garbage collector from large numbers of
    small allocations in forms with many parts. ReadForm could allocate a large
    number of short-lived buffers, further increasing pressure on the garbage
    collector. The combination of these factors can permit an attacker to cause an
    program that parses multipart forms to consume large amounts of CPU and
    memory, potentially resulting in a denial of service. This affects programs
    that use mime/multipart.Reader.ReadForm, as well as form parsing in the
    net/http package with the Request methods FormFile, FormValue,
    ParseMultipartForm, and PostFormValue.

    ReadForm now does a better job of estimating the memory consumption of parsed
    forms, and performs many fewer short-lived allocations.

    In addition, mime/multipart.Reader now imposes the following limits on the
    size of parsed forms:

    Forms parsed with ReadForm may contain no more than 1000 parts. This limit may
    be adjusted with the environment variable GODEBUG=multipartmaxparts=. Form
    parts parsed with NextPart and NextRawPart may contain no more than 10,000
    header fields. In addition, forms parsed with ReadForm may contain no more
    than 10,000 header fields across all parts. This limit may be adjusted with
    the environment variable GODEBUG=multipartmaxheaders=.

    Thanks to Jakob Ackermann for discovering this issue.

    This is CVE-2023-24536 and Go issue https://go.dev/issue/59153.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah

Copy link
Copy Markdown
Member Author

oh! interesting; vendor check is failing. I suspect we back ported a PR that was "clean" but made an "indirect" a "direct" dependency (not sure why CI didn't catch that though

diff --git a/vendor.mod b/vendor.mod
index 6978a487a9..55852937b3 100644
--- a/vendor.mod
+++ b/vendor.mod
@@ -42,6 +42,7 @@ require (
 	github.com/gorilla/mux v1.8.0
 	github.com/hashicorp/go-immutable-radix v1.3.1
 	github.com/hashicorp/go-memdb v1.3.2
+	github.com/hashicorp/go-multierror v1.1.1
 	github.com/hashicorp/memberlist v0.4.0
 	github.com/hashicorp/serf v0.8.5
 	github.com/imdario/mergo v0.3.12
@@ -125,7 +126,6 @@ require (
 	github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
 	github.com/hashicorp/errwrap v1.1.0 // indirect
 	github.com/hashicorp/go-msgpack v0.5.5 // indirect
-	github.com/hashicorp/go-multierror v1.1.1 // indirect
 	github.com/hashicorp/go-sockaddr v1.0.2 // indirect
 	github.com/hashicorp/golang-lru v0.5.4 // indirect
 	github.com/inconshreveable/mousetrap v1.0.1 // indirect
make: *** [Makefile:217: validate-vendor] Error 1
Error: Process completed with exit code 2.

@thaJeztah

Copy link
Copy Markdown
Member Author

Looks like we had this on master as well (but possibly due to a different PR);
#44453

Looks like on the 23.0 branch it was the GHSA-232p-vwff-86mp commit; 59118bf

@thaJeztah

Copy link
Copy Markdown
Member Author

go1.19.8 (released 2023-04-04) includes security fixes to the go/parser,
html/template, mime/multipart, net/http, and net/textproto packages, as well as
bug fixes to the linker, the runtime, and the time package. See the Go 1.19.8
milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.19.8+label%3ACherryPickApproved

full diff: golang/go@go1.19.7...go1.19.8

Further details from the announcement on the mailing list:

We have just released Go versions 1.20.3 and 1.19.8, minor point releases.
These minor releases include 4 security fixes following the security policy:

- go/parser: infinite loop in parsing

  Calling any of the Parse functions on Go source code which contains `//line`
  directives with very large line numbers can cause an infinite loop due to
  integer overflow.
  Thanks to Philippe Antoine (Catena cyber) for reporting this issue.
  This is CVE-2023-24537 and Go issue https://go.dev/issue/59180.

- html/template: backticks not treated as string delimiters

  Templates did not properly consider backticks (`) as Javascript string
  delimiters, and as such did not escape them as expected. Backticks are
  used, since ES6, for JS template literals. If a template contained a Go
  template action within a Javascript template literal, the contents of the
  action could be used to terminate the literal, injecting arbitrary Javascript
  code into the Go template.

  As ES6 template literals are rather complex, and themselves can do string
  interpolation, we've decided to simply disallow Go template actions from being
  used inside of them (e.g. "var a = {{.}}"), since there is no obviously safe
  way to allow this behavior. This takes the same approach as
  github.com/google/safehtml. Template.Parse will now return an Error when it
  encounters templates like this, with a currently unexported ErrorCode with a
  value of 12. This ErrorCode will be exported in the next major release.

  Users who rely on this behavior can re-enable it using the GODEBUG flag
  jstmpllitinterp=1, with the caveat that backticks will now be escaped. This
  should be used with caution.

  Thanks to Sohom Datta, Manipal Institute of Technology, for reporting this issue.

  This is CVE-2023-24538 and Go issue https://go.dev/issue/59234.

- net/http, net/textproto: denial of service from excessive memory allocation

  HTTP and MIME header parsing could allocate large amounts of memory, even when
  parsing small inputs.

  Certain unusual patterns of input data could cause the common function used to
  parse HTTP and MIME headers to allocate substantially more memory than
  required to hold the parsed headers. An attacker can exploit this behavior to
  cause an HTTP server to allocate large amounts of memory from a small request,
  potentially leading to memory exhaustion and a denial of service.
  Header parsing now correctly allocates only the memory required to hold parsed
  headers.

  Thanks to Jakob Ackermann (@das7pad) for discovering this issue.

  This is CVE-2023-24534 and Go issue https://go.dev/issue/58975.

- net/http, net/textproto, mime/multipart: denial of service from excessive resource consumption

  Multipart form parsing can consume large amounts of CPU and memory when
  processing form inputs containing very large numbers of parts. This stems from
  several causes:

  mime/multipart.Reader.ReadForm limits the total memory a parsed multipart form
  can consume. ReadForm could undercount the amount of memory consumed, leading
  it to accept larger inputs than intended. Limiting total memory does not
  account for increased pressure on the garbage collector from large numbers of
  small allocations in forms with many parts. ReadForm could allocate a large
  number of short-lived buffers, further increasing pressure on the garbage
  collector. The combination of these factors can permit an attacker to cause an
  program that parses multipart forms to consume large amounts of CPU and
  memory, potentially resulting in a denial of service. This affects programs
  that use mime/multipart.Reader.ReadForm, as well as form parsing in the
  net/http package with the Request methods FormFile, FormValue,
  ParseMultipartForm, and PostFormValue.

  ReadForm now does a better job of estimating the memory consumption of parsed
  forms, and performs many fewer short-lived allocations.

  In addition, mime/multipart.Reader now imposes the following limits on the
  size of parsed forms:

  Forms parsed with ReadForm may contain no more than 1000 parts. This limit may
  be adjusted with the environment variable GODEBUG=multipartmaxparts=. Form
  parts parsed with NextPart and NextRawPart may contain no more than 10,000
  header fields. In addition, forms parsed with ReadForm may contain no more
  than 10,000 header fields across all parts. This limit may be adjusted with
  the environment variable GODEBUG=multipartmaxheaders=.

  Thanks to Jakob Ackermann for discovering this issue.

  This is CVE-2023-24536 and Go issue https://go.dev/issue/59153.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah force-pushed the 23.0_bump_go1.19.8 branch from cbbb6d2 to d3e5293 Compare April 5, 2023 20:02
@thaJeztah

Copy link
Copy Markdown
Member Author

(rebased to get the fix from #45279 in)

@thaJeztah

Copy link
Copy Markdown
Member Author

All green now; I'll assume there won't be objections against bringing this one in; let me merge

@thaJeztah
thaJeztah merged commit 4ca4705 into moby:23.0 Apr 5, 2023
@thaJeztah
thaJeztah deleted the 23.0_bump_go1.19.8 branch April 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.