remove deprecated support for overlay(2) on backing FS without d_type (fstype=1)#43472
Merged
Merged
remove deprecated support for overlay(2) on backing FS without d_type (fstype=1)#43472
Conversation
… (fstype=1) Support for overlay on a backing filesystem without d_type was deprecated in 0abb8de (Docker 17.12), with an exception for existing installations (0a4e793). That deprecation was nearly 5 years ago, and running without d_type is known to cause serious issues (so users will likely already have run into other problems). This patch removes support for running overlay and overlay2 on these filesystems, returning the error instead of logging it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's no longer used, and has no external consumers. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tianon
approved these changes
Apr 8, 2022
AkihiroSuda
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for overlay on a backing filesystem without d_type was deprecated in 0abb8de (#35514, Docker 17.12), with an exception for existing installations (0a4e793, #35514).
That deprecation was nearly 5 years ago, and running without d_type is known to cause serious issues (so users will likely already have run into other problems).
This patch removes support for running overlay and overlay2 on these filesystems, returning the error instead of logging it.
daemon/graphdriver: remove unused
graphdriver.IsInitialized()It's no longer used, and has no external consumers.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)