rootless: graduate from experimental#40759
Merged
thaJeztah merged 2 commits intoApr 7, 2020
moby:mastermoby/moby:masterfrom
AkihiroSuda:move-rootless-out-of-experimentalAkihiroSuda/docker:move-rootless-out-of-experimentalCopy head branch name to clipboard
Merged
rootless: graduate from experimental#40759thaJeztah merged 2 commits intomoby:mastermoby/moby:masterfrom AkihiroSuda:move-rootless-out-of-experimentalAkihiroSuda/docker:move-rootless-out-of-experimentalCopy head branch name to clipboard
thaJeztah merged 2 commits into
moby:mastermoby/moby:masterfrom
AkihiroSuda:move-rootless-out-of-experimentalAkihiroSuda/docker:move-rootless-out-of-experimentalCopy head branch name to clipboard
Conversation
AkihiroSuda
force-pushed
the
move-rootless-out-of-experimental
branch
from
March 31, 2020 07:51
af30fe7 to
5e02308
Compare
Member
Author
|
@thaJeztah PTAL? |
Member
|
oh, actually; not a blocker, but can you also update the Jenkinsfile? Line 411 in c239bbb |
Member
Author
|
Intentionally left Jenkinsfile as-is, because I thought we should still test other experimental features with rootless. WDYT? |
Member
|
Gotcha; no need to change; I don't think it's even needed, because the global env-var already enables it (so should be inherited); https://github.com/moby/moby/blob/master/Jenkinsfile#L24 |
Close moby#40484 Note that the support for cgroup v2 isn't ready for production yet, regardless to rootful or rootless. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
DOCKER_EXPERIMENTAL is already set in the head of the file. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
updated Jenkinsfile |
AkihiroSuda
force-pushed
the
move-rootless-out-of-experimental
branch
from
April 6, 2020 15:59
5e02308 to
d1304a8
Compare
Member
Author
|
@tianon @tonistiigi @tiborvass PTAL |
tonistiigi
approved these changes
Apr 7, 2020
Member
|
bringing this one in; @AkihiroSuda can you check if the documentation needs updating and open a "draft" PR for that if needed? |
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
Apr 29, 2020
Follow up to moby#40759 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #40484
Note that the support for cgroup v2 isn't ready for production yet, regardless to rootful or rootless.