Alternative failure mitigation of TestExecInteractiveStdinClose#37143
Merged
Merged
Alternative failure mitigation of TestExecInteractiveStdinClose#37143
TestExecInteractiveStdinClose#37143Conversation
Contributor
Author
|
/cc @thaJeztah @vdemeester, I've been thinking what the root cause is when driving to the office, after check some |
arm64b
force-pushed
the
copy-after-command-exit
branch
from
May 24, 2018 02:58
cc42d1c to
5bd4642
Compare
Codecov Report
@@ Coverage Diff @@
## master #37143 +/- ##
=========================================
Coverage ? 35.05%
=========================================
Files ? 615
Lines ? 45828
Branches ? 0
=========================================
Hits ? 16065
Misses ? 27652
Partials ? 2111 |
Begin to copy the data until the command to exit and any coping to stdin or copy from stdout/stderr has completed. Also adding defense code to trim the possible '\x00' null value. Signed-off-by: Dennis Chen <dennis.chen@arm.com>
arm64b
force-pushed
the
copy-after-command-exit
branch
from
May 28, 2018 03:27
5bd4642 to
386e0f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up of #37076
Begin to copy the data until the command to exit and any coping to stdin or copy from stdout/stderr has completed.
Also add the defense code to remove possible
\x00null character from the final buffer.Signed-off-by: Dennis Chen dennis.chen@arm.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)