Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix panic on error looking up volume driver#32347

Merged
vdemeester merged 1 commit into
moby:mastermoby/moby:masterfrom
cpuguy83:fix_volumestore_paniccpuguy83/docker:fix_volumestore_panicCopy head branch name to clipboard
Apr 4, 2017
Merged

Fix panic on error looking up volume driver#32347
vdemeester merged 1 commit into
moby:mastermoby/moby:masterfrom
cpuguy83:fix_volumestore_paniccpuguy83/docker:fix_volumestore_panicCopy head branch name to clipboard

Conversation

@cpuguy83

@cpuguy83 cpuguy83 commented Apr 4, 2017

Copy link
Copy Markdown
Member

Signed-off-by: Brian Goff cpuguy83@gmail.com

- What I did

............................................________ 
....................................,.-'"...................``~., 
.............................,.-"..................................."-., 
.........................,/...............................................":, 
.....................,?......................................................, 
.................../...........................................................,} 
................./......................................................,:`^`..} 
.............../...................................................,:"........./ 
..............?.....__.........................................:`.........../ 
............./__.(....."~-,_..............................,:`........../ 
.........../(_...."~,_........"~,_....................,:`........_/ 
..........{.._$;_......"=,_......."-,_.......,.-~-,},.~";/....} 
...........((.....*~_......."=-._......";,,./`..../"............../ 
...,,,___.`~,......"~.,....................`.....}............../ 
............(....`=-,,.......`........................(......;_,,-" 
............/.`~,......`-...................................../ 
.............`~.*-,.....................................|,./.....,__ 
,,_..........}.>-._...................................|..............`=~-, 
.....`=~-,__......`,................................. 
...................`=~-,,.,............................... 
................................`:,,...........................`..............__ 
.....................................`=-,...................,%`>--==`` 
........................................_..........._,-%.......` 
...................................,

- How I did it
http://www.asciifacepalm.com/
- How to verify it

- Description for the changelog
(－‸ლ)

- A picture of a cute animal (not mandatory but encouraged)

download

@cpuguy83
Fix panic on error looking up volume driver
5baf8a4 
(－‸ლ)

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
vdemeester
vdemeester approved these changes Apr 4, 2017
View reviewed changes

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

thaJeztah
thaJeztah approved these changes Apr 4, 2017
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Apr 4, 2017

Copy link
Copy Markdown
Member

is this issue in a release already?

@cpuguy83

cpuguy83 commented Apr 4, 2017

Copy link
Copy Markdown
Member Author

Yes, though likely uncommon.

@vdemeester
vdemeester merged commit f6b7dc9 into moby:master Apr 4, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Apr 4, 2017
@cpuguy83
cpuguy83 deleted the fix_volumestore_panic branch May 5, 2017 18:34
@thaJeztah thaJeztah mentioned this pull request May 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes
+1 more reviewer
@vdemeester vdemeester vdemeester approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/4-merge

Projects

None yet

Milestone

17.05.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cpuguy83 @thaJeztah @vdemeester @GordonTheTurtle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.