Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

絵文字ピッカーの検索クエリの小文字変換をなくす#17743

Open
FineArchs wants to merge 2 commits into
misskey-dev:developmisskey-dev/misskey:developfrom
FineArchs:FineArchs-patch-1FineArchs/misskey:FineArchs-patch-1Copy head branch name to clipboard
Open

絵文字ピッカーの検索クエリの小文字変換をなくす#17743
FineArchs wants to merge 2 commits into
misskey-dev:developmisskey-dev/misskey:developfrom
FineArchs:FineArchs-patch-1FineArchs/misskey:FineArchs-patch-1Copy head branch name to clipboard

Conversation

@FineArchs

@FineArchs FineArchs commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

絵文字ピッカーの検索時、検索文字列を小文字に変換してから検索しているのをそのまま検索するようにします。

Why

現在の絵文字ピッカーの動作では、検索文字列だけ小文字化してタグはそのまま検索を行っているため、ただ大文字を含むタグの検索ができないだけになっています。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 18, 2026
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label Jul 18, 2026
@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c1ee7b8a-d3ac-4a42-8ba7-b73af585fbba

📥 Commits

Reviewing files that changed from the base of the PR and between bdf1547 and d00e2a1.

📒 Files selected for processing (1)
  • packages/frontend/src/components/MkEmojiPicker.vue
📝 Walkthrough

Walkthrough

絵文字ピッカーの検索クエリ生成を変更し、コロンを除去した後も大文字小文字を変換せず、そのまま検索条件へ渡すようにしました。

Changes

絵文字検索

Layer / File(s) Summary
検索クエリの大文字小文字保持
packages/frontend/src/components/MkEmojiPicker.vue		 検索クエリ生成時の toLowerCase() を削除し、コロン除去後の大文字小文字を保持します。

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

コロンひとつをそっと消し
大文字小文字はそのままに
絵文字の森を検索します
文字の姿を変えずに進み
ぴったりの笑顔を見つけます 😊

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 絵文字ピッカーの検索クエリから小文字変換を外す変更を、具体的かつ簡潔に表しています。
Description check ✅ Passed What/Why/Checklistが揃っており、変更目的も明確です。任意の追加情報が未記入でも問題ありません。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 13.98%. Comparing base (d2973ec) to head (b37e235).

Files with missing lines Patch % Lines
packages/frontend/src/components/MkEmojiPicker.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #17743       +/-   ##
============================================
- Coverage    26.99%   13.98%   -13.01%     
============================================
  Files         1185      248      -937     
  Lines        40638    12025    -28613     
  Branches     11245     4045     -7200     
============================================
- Hits         10971     1682     -9289     
+ Misses       23803     8099    -15704     
+ Partials      5864     2244     -3620

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

📦 Frontend Bundle Report

Chunk size diff (0 updated, 0 added, 0 removed)
Chunk Before After Δ Δ (%)
(total) 5.9 MB 5.9 MB $\text{-14 B}$ $\text{-0\%}$
(other generated chunks) 2 MB 2 MB $\text{-14 B}$ $\text{-0\%}$
Startup chunk size (0 updated, 0 added, 0 removed)
Chunk Before After Δ Δ (%)
(total) 1 MB 1 MB $\text{-14 B}$ $\text{-0\%}$
(other generated chunks) 753 KB 753 KB $\text{-14 B}$ $\text{-0\%}$
(other) 280 KB 280 KB 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundle Stats

,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Before 467 2,867 21 8,609 324 10 MB 2.8 MB 2.4 MB
After 467 2,867 21 8,609 324 10 MB 2.8 MB 2.4 MB
Δ 0 0 0 0 0 $\text{-115 B}$ $\text{-79 B}$ $\text{+59 B}$
Δ (%) 0% 0% 0% 0% 0% $\text{-0\%}$ $\text{-0\%}$ $\text{+0\%}$

Open treemap HTML

@Sayamame-beans

Sayamame-beans commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

related issue: #6489 #11308
related pr: #11321

なお、 #15632 にて複数の事項を考慮した文字列比較用の関数が実装されたものの、現状未使用です
(再考: ひとまず大文字小文字のみの対応でも十分な可能性があります。なお、絵文字名に大文字が使える事自体が不具合に近いという話が出たこともありました)

@coderabbitai coderabbitai Bot mentioned this pull request Jul 20, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packages/frontend Client side specific issue/PR size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

[実験中] 管理用
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FineArchs @Sayamame-beans @syuilo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.