This repository was archived by the owner on Apr 25, 2026. It is now read-only.
fix boundary value bug when objTime ends in whole seconds (without sub-second) - #21419
#21419Merged
harshavardhana merged 2 commits intoJul 23, 2025
Merged
fix boundary value bug when objTime ends in whole seconds (without sub-second)#21419harshavardhana merged 2 commits into
harshavardhana merged 2 commits into
Conversation
harshavardhana
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
When objTime ends in whole seconds (without sub-second) and it is just 1 second after givenTime, ifModifiedSince() returns false instead of true
Motivation and Context
Fix a boundary value bug I encounter
How to test this PR?
Given these values:
Request should return 200, not 304
Types of changes
Checklist:
commit-idorPR #here)