This repository was archived by the owner on Apr 25, 2026. It is now read-only.
Allow FTPS to force TLS - #21251
#21251Merged
Merged
Conversation
Fixes minio#21249 Example params: `-ftp=force-tls=true -ftp="tls-private-key=ftp/private.key" -ftp="tls-public-cert=ftp/public.crt"` If MinIO is set up for TLS those certs will be used.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new flag to force TLS when using FTPS, allowing users to ensure that TLS is enforced when launching the FTP server.
- Introduces a new boolean flag ("force-tls") that is parsed from startup arguments
- Adds a check to validate that TLS is properly configured when forceTLS is enabled, and passes the flag to the FTP server initialization
Files not reviewed (1)
- docs/debugging/inspect/go.mod: Language not supported
Contributor
|
Should this option be documented? I'm not sure if it is visible in the |
Contributor
Author
|
@feorlen Where are these params documented? Looked for it, but didn't find anything obvious. |
Contributor
|
@klauspost the ftp settings are on the MinIO Server page: |
Contributor
Author
|
@feorlen Thanks! Something like this:
|
marktheunissen
approved these changes
Apr 30, 2025
harshavardhana
approved these changes
May 9, 2025
harshavardhana
pushed a commit
that referenced
this pull request
May 30, 2025
Fixes #21249 Example params: `-ftp=force-tls=true -ftp="tls-private-key=ftp/private.key" -ftp="tls-public-cert=ftp/public.crt"` If MinIO is set up for TLS those certs will be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21249
Example params:
-ftp=force-tls=true -ftp="tls-private-key=ftp/private.key" -ftp="tls-public-cert=ftp/public.crt"If MinIO is set up for TLS those certs will be used.
How to test this PR?
Add
-ftp=force-tls=trueto startup.Types of changes