Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

compatibility with 11-bit CAN messaging  #18

Copy link
Copy link

Description

@DaveP987
Issue body actions

Hello Miller,

I'm on a project where I need to support simultaneous 11-bit and J1939 messaging. I've hacked this package a bit to make it work (it doesn't really take much) and thought I could make a contribution to provide that support.

The changes include:

  1. building J1939 filters on any specified can_filters,
  2. dispatching incoming non-PDU messages to a method that still ignores them but can be sub-classed for addition to the queue,
  3. dispatching outgoing non-PDU messages directly to self.can_bus.send

Another change I made was to put the construction of RawCanBus into a method so a sub-class can swap in a dummy bus for tests.

Dave

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.