feature/http client configuration#501
Merged
baywet merged 4 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom Oct 2, 2020
feature/http-client-configurationmicrosoftgraph/msgraph-sdk-java:feature/http-client-configurationCopy head branch name to clipboard
Merged
feature/http client configuration#501baywet merged 4 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom feature/http-client-configurationmicrosoftgraph/msgraph-sdk-java:feature/http-client-configurationCopy head branch name to clipboard
baywet merged 4 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
feature/http-client-configurationmicrosoftgraph/msgraph-sdk-java:feature/http-client-configurationCopy head branch name to clipboard
Conversation
Collaborator
MIchaelMainer
left a comment
There was a problem hiding this comment.
Can you help me understand how these changes relate with msgraph-sdk-java-core? We should use core for http client configuration.
Member
Author
|
@MIchaelMainer I have to admit I have mixed a few things here:
|
zengin
suggested changes
Oct 2, 2020
This was referenced Oct 2, 2020
| * @param <T1> the http client type | ||
| * @return the HTTP provider | ||
| */ | ||
| <T1> IHttpProvider getHttpProvider(final T1 httpClient); |
Collaborator
There was a problem hiding this comment.
How come we aren't seeing a compile time issue with this not being implemented in DefaultClientConfig.java
Member
Author
There was a problem hiding this comment.
because that class is abstract?
Member
Author
There was a problem hiding this comment.
no, actually because I've implemented it https://github.com/microsoftgraph/msgraph-sdk-java/pull/501/files#diff-f4a32244a27971a081fa72ffb340ca67R113
zengin
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #162