feature/super callbacks#498
Merged
baywet merged 3 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom Sep 23, 2020
feature/super-callbacksmicrosoftgraph/msgraph-sdk-java:feature/super-callbacksCopy head branch name to clipboard
Merged
feature/super callbacks#498baywet merged 3 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom feature/super-callbacksmicrosoftgraph/msgraph-sdk-java:feature/super-callbacksCopy head branch name to clipboard
baywet merged 3 commits intodevmicrosoftgraph/msgraph-sdk-java:devfrom
feature/super-callbacksmicrosoftgraph/msgraph-sdk-java:feature/super-callbacksCopy head branch name to clipboard
Conversation
This was referenced Sep 23, 2020
MIchaelMainer
approved these changes
Sep 23, 2020
Collaborator
MIchaelMainer
left a comment
There was a problem hiding this comment.
Reviewed the generator changes.
davidmoten
approved these changes
Sep 23, 2020
Contributor
davidmoten
left a comment
There was a problem hiding this comment.
LTGM on a quick scan of generated files only (test not findable in github ui because of number of changed files).
Member
Author
Thanks for giving it a look. I usually try to group the code Gen in one commit and have the other changes in other commits in this cases. This way you can still review easily commit by commit and skip the code Gen one FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #24