Select causes 400 bad request#197
Closed
Krisoblucki-okta wants to merge 2 commits intomicrosoftgraph:devmicrosoftgraph/msgraph-sdk-java:devfrom
Krisoblucki-okta:select-causes-400-bad-requestKrisoblucki-okta/msgraph-sdk-java:select-causes-400-bad-requestCopy head branch name to clipboard
Closed
Select causes 400 bad request#197Krisoblucki-okta wants to merge 2 commits intomicrosoftgraph:devmicrosoftgraph/msgraph-sdk-java:devfrom Krisoblucki-okta:select-causes-400-bad-requestKrisoblucki-okta/msgraph-sdk-java:select-causes-400-bad-requestCopy head branch name to clipboard
Krisoblucki-okta wants to merge 2 commits intomicrosoftgraph:devmicrosoftgraph/msgraph-sdk-java:devfrom
Krisoblucki-okta:select-causes-400-bad-requestKrisoblucki-okta/msgraph-sdk-java:select-causes-400-bad-requestCopy head branch name to clipboard
Conversation
8bd2e4f to
ea52b3c
Compare
Further changes are required to the generated java files
ea52b3c to
1729fac
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
thanks for your patience on the matter. I just authored microsoftgraph/MSGraph-SDK-Code-Generator#281 which fixes the issue by passing only the header options and you can see the resulting code changes in #445 . |
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core change to be able to fix #193
Changes proposed in this pull request
Logic to retrieve base request url and retrieve after mutation needs to be decoupled