- fixes a bug where url options would be inserted twice for collection POST requests#281
Merged
baywet merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom Sep 3, 2020
bugfix/collection-post-duplicate-optionsmicrosoftgraph/MSGraph-SDK-Code-Generator:bugfix/collection-post-duplicate-optionsCopy head branch name to clipboard
Merged
- fixes a bug where url options would be inserted twice for collection POST requests#281baywet merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom bugfix/collection-post-duplicate-optionsmicrosoftgraph/MSGraph-SDK-Code-Generator:bugfix/collection-post-duplicate-optionsCopy head branch name to clipboard
baywet merged 2 commits intodevmicrosoftgraph/MSGraph-SDK-Code-Generator:devfrom
bugfix/collection-post-duplicate-optionsmicrosoftgraph/MSGraph-SDK-Code-Generator:bugfix/collection-post-duplicate-optionsCopy head branch name to clipboard
Conversation
This was referenced Sep 3, 2020
Contributor
|
I understand the removal of My assumption looking at the code change is that |
Member
Author
|
yes we're only keeping the request headers. That's because getrequesturl already adds the functions and query parameters in the URL but not the headers. |
zengin
approved these changes
Sep 3, 2020
Contributor
zengin
left a comment
There was a problem hiding this comment.
Thanks for the clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Because getRequestUrl already inserts the options (functions and query), providing the options again in build request was inserting those twice, causing the request to fail.
Generated code differences
microsoftgraph/msgraph-sdk-java#445
Command line arguments to run these changes
Provide the command line arguments here so that reviewers can quickly repro the results of changes.
Links to issues or work items this PR addresses