Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix executable bitness for testhost.x86 - #4652

#4652
Merged
nohwnd merged 7 commits into
mainmicrosoft/vstest:mainfrom
noblmicrosoft/vstest:noblCopy head branch name to clipboard
Aug 14, 2023
Merged

Fix executable bitness for testhost.x86#4652
nohwnd merged 7 commits into
mainmicrosoft/vstest:mainfrom
noblmicrosoft/vstest:noblCopy head branch name to clipboard

Conversation

@nohwnd

@nohwnd nohwnd commented Aug 11, 2023

Copy link
Copy Markdown
Member

Fixes those issues in 17.8.0 but we need to backport and release 17.7.1:

Related #4650
Related AB#1866640'
Related #4645

Remove + from the final version.
Fix the bitness of our executables. Will plug that script later into build, IDK if both those tools are on hosted images, and on everyones computers.

@nohwnd nohwnd changed the title No binlog from Test.cmd -integrationTest Fix executable bitness for testhost.x86 Aug 11, 2023
@@ -0,0 +1,8 @@
Get-ChildItem S:\p\vstest3\artifacts\packages\Debug\Shipping -Filter vstest.console.exe -Recurse -Force | ForEach-Object {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this path linked to your machine setup?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am aware of that, answer to all the same questions below is in the PR description. I just did not want to lose that code.

Will plug that script later into build, IDK if both those tools are on hosted images, and on everyones computers.

Comment thread eng/verify-nupkgs-exe.ps1
Comment thread eng/verify-nupkgs-exe.ps1
Comment thread eng/verify-nupkgs-exe.ps1
Comment thread src/DataCollectors/DumpMinitool.arm64/DumpMinitool.arm64.csproj Outdated
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
@nohwnd
nohwnd enabled auto-merge (squash) August 14, 2023 07:17
@nohwnd

nohwnd commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd

nohwnd commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd
nohwnd merged commit 5e505c8 into main Aug 14, 2023
@nohwnd
nohwnd deleted the nobl branch August 14, 2023 13:46
nohwnd added a commit to nohwnd/vstest that referenced this pull request Aug 14, 2023
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
cvpoienaru pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
This was referenced Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.