Fix mutex cleanup crash on macOS/Linux - #15684
#15684Merged
nohwnd merged 2 commits intoApr 16, 2026
microsoft:mainmicrosoft/vstest:mainfrom
nohwnd:fix-mutex-cleanup-macosnohwnd/vstest:fix-mutex-cleanup-macosCopy head branch name to clipboard
Merged
Fix mutex cleanup crash on macOS/Linux#15684nohwnd merged 2 commits intomicrosoft:mainmicrosoft/vstest:mainfrom nohwnd:fix-mutex-cleanup-macosnohwnd/vstest:fix-mutex-cleanup-macosCopy head branch name to clipboard
nohwnd merged 2 commits into
microsoft:mainmicrosoft/vstest:mainfrom
nohwnd:fix-mutex-cleanup-macosnohwnd/vstest:fix-mutex-cleanup-macosCopy head branch name to clipboard
Conversation
AssemblyCleanup may run on a different thread than AssemblyInitialize. On macOS/Linux the runtime throws InvalidOperationException (not ApplicationException) when ReleaseMutex is called from a non-owning thread. Widen the catch to handle both platforms. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts integration test asset cleanup to avoid crashes when AssemblyCleanup runs on a different thread than AssemblyInitialize, which can cause Mutex.ReleaseMutex() to throw different exception types on macOS/Linux vs Windows.
Changes:
- Adds explanatory comments about cross-thread
ReleaseMutex()behavior across platforms. - Broadens the exception handling around
ReleaseMutex()during cleanup.
nohwnd
enabled auto-merge (squash)
April 16, 2026 13:30
Evangelink
approved these changes
Apr 16, 2026
This was referenced Jul 14, 2026
Closed
This was referenced Jul 27, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssemblyCleanup may run on a different thread than AssemblyInitialize. On macOS/Linux the .NET runtime throws InvalidOperationException (not ApplicationException) when ReleaseMutex() is called from a non-owning thread. This widens the catch to handle both platforms.