Add an icon for the "Run Python File in Terminal" command. - #6498
#6498Merged
ericsnowcurrently merged 21 commits intoJul 29, 2019
microsoft:mastermicrosoft/vscode-python:masterfrom
ericsnowcurrently:run-in-terminal-iconericsnowcurrently/vscode-python:run-in-terminal-iconCopy head branch name to clipboard
Merged
Add an icon for the "Run Python File in Terminal" command.#6498ericsnowcurrently merged 21 commits intomicrosoft:mastermicrosoft/vscode-python:masterfrom ericsnowcurrently:run-in-terminal-iconericsnowcurrently/vscode-python:run-in-terminal-iconCopy head branch name to clipboard
ericsnowcurrently merged 21 commits into
microsoft:mastermicrosoft/vscode-python:masterfrom
ericsnowcurrently:run-in-terminal-iconericsnowcurrently/vscode-python:run-in-terminal-iconCopy head branch name to clipboard
Conversation
karrtikr
approved these changes
Jul 9, 2019
DonJayamanne
requested changes
Jul 10, 2019
Author
|
FYI, this is blocked on getting the final icons. |
Author
|
@karrtikr, yeah, we're going to ship the experiment. |
karrtikr
suggested changes
Jul 10, 2019
ericsnowcurrently
force-pushed
the
run-in-terminal-icon
branch
from
July 11, 2019 21:52
9b72514 to
cf1de35
Compare
karrtikr
suggested changes
Jul 16, 2019
karrtikr
reviewed
Jul 16, 2019
Author
|
So once I've added tests we're good to go? |
karrtikr
approved these changes
Jul 16, 2019
DonJayamanne
requested changes
Jul 17, 2019
rchiodo
reviewed
Jul 17, 2019
rchiodo
reviewed
Jul 17, 2019
DonJayamanne
approved these changes
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #5321)
Note that we will add the final icons once they are settled. Until then we use placeholders.
Also note that I called the experiment "ShowPlayIcon".
[ ] Unit tests & system/integration tests are added/updated[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.