Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4bc7ff7

Browse filesBrowse files
authored
Add needs to CI coverage check (#24421)
Fixes #23052 Added "needs" to the Coverage check, so it only runs if all the previous tests mentioned pass. ![image](https://github.com/user-attachments/assets/9ba79542-5327-457a-b7cd-2e26d0f3ce7e) We could also set `fail-fast` to `true` if we want to stop the workflow when any tests fail. Please let me know if it needs any modifications.
1 parent 006dd23 commit 4bc7ff7
Copy full SHA for 4bc7ff7

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed

‎.github/workflows/pr-check.yml

Copy file name to clipboardExpand all lines: .github/workflows/pr-check.yml
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,7 @@ jobs:
461461
name: Coverage
462462
# The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
463463
runs-on: ${{ matrix.os }}
464+
needs: [lint, check-types, python-tests, tests, native-tests]
464465
strategy:
465466
fail-fast: false
466467
matrix:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.