Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Have CI coverage require other tests passing #23052

Copy link
Copy link
Closed
@brettcannon

Description

@brettcannon
Issue body actions

There's no needs clause on coverage in PR CI, which means if the tests are definitely going to fail then they will fail twice: once for the normal test run and then again when run under coverage. Either coverage should be the way to run those tests so they aren't run twice or coverage should probably not run if the test suite failed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-internalLabel for non-user facing issuesLabel for non-user facing issuesdebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.good first issueneeds PRReady to be worked onReady to be worked on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.