Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix incorrect compiler path with spaces and args squiggle.#5217

Merged
sean-mcmanus merged 2 commits into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/fixCompilerArgSquigglemicrosoft/vscode-cpptools:seanmcm/fixCompilerArgSquiggleCopy head branch name to clipboard
Mar 28, 2020
Merged

Fix incorrect compiler path with spaces and args squiggle.#5217
sean-mcmanus merged 2 commits into
mastermicrosoft/vscode-cpptools:masterfrom
seanmcm/fixCompilerArgSquigglemicrosoft/vscode-cpptools:seanmcm/fixCompilerArgSquiggleCopy head branch name to clipboard

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Mar 27, 2020

Copy link
Copy Markdown
Contributor

Fixes #5215

@sean-mcmanus sean-mcmanus added this to the 0.27.0 milestone Mar 27, 2020
@sean-mcmanus sean-mcmanus requested a review from a team March 27, 2020 23:22
Comment thread Extension/src/LanguageServer/configurations.ts
Comment thread Extension/src/LanguageServer/configurations.ts
@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

Yeah, good catch -- without the change the UI shows the error still.

@sean-mcmanus sean-mcmanus merged commit 913ddf4 into master Mar 28, 2020
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixCompilerArgSquiggle branch March 28, 2020 00:02
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler path with spaces produces error

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.