Fix version filtering for removing unused binaries#5175
Merged
michelleangela merged 1 commit intoMar 24, 2020
mastermicrosoft/vscode-cpptools:masterfrom
mimatias/delete-old-lldbmimicrosoft/vscode-cpptools:mimatias/delete-old-lldbmiCopy head branch name to clipboard
Merged
Fix version filtering for removing unused binaries#5175michelleangela merged 1 commit intomastermicrosoft/vscode-cpptools:masterfrom mimatias/delete-old-lldbmimicrosoft/vscode-cpptools:mimatias/delete-old-lldbmiCopy head branch name to clipboard
michelleangela merged 1 commit into
mastermicrosoft/vscode-cpptools:masterfrom
mimatias/delete-old-lldbmimicrosoft/vscode-cpptools:mimatias/delete-old-lldbmiCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to filter in packages that do not match the version for the host platform was also incorrectly filtering in binaries for a different platform.
This fix only filters in versions that do not match.