Undo bad fix for check in getVcpkgRoot#5116
Merged
Colengms merged 2 commits intoMar 13, 2020
mastermicrosoft/vscode-cpptools:masterfrom
coleng/fix_getVcpkgRootmicrosoft/vscode-cpptools:coleng/fix_getVcpkgRootCopy head branch name to clipboard
Merged
Undo bad fix for check in getVcpkgRoot#5116Colengms merged 2 commits intomastermicrosoft/vscode-cpptools:masterfrom coleng/fix_getVcpkgRootmicrosoft/vscode-cpptools:coleng/fix_getVcpkgRootCopy head branch name to clipboard
Colengms merged 2 commits into
mastermicrosoft/vscode-cpptools:masterfrom
coleng/fix_getVcpkgRootmicrosoft/vscode-cpptools:coleng/fix_getVcpkgRootCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Mar 13, 2020
| let vcpkgRoot: string | undefined; | ||
| export function getVcpkgRoot(): string { | ||
| if (!vcpkgRoot) { | ||
| if (!vcpkgRoot && vcpkgRoot !== "") { |
Contributor
There was a problem hiding this comment.
Yeah, I noticed that when I code reviewed...I was thinking about asking what that was for :)
Contributor
Author
There was a problem hiding this comment.
It looks like it's using a value of "" to indicate that it has attempted and failed, so does not attempt again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.