Does it fallback to the shipped clang-format if it's not found on the path? Also, I think we should have a way to specify to "use the clang-format shipped with the C/C++ extension", because a hardcoded path won't work because the version will change every new release. Maybe some {default} or {bundled} variable? Also, maybe the description of the clang_format_path should be updated?

I'm not convinced that falling back to the bundled version if someone has incorrectly configured their path, would be the right thing to do, as it would silently fail to use the setting they provided. IMHO, it would be better to fail. Also, I'm not convinced a new setting to override the behavior makes sense. I think using the version installed on the system should be preferred, and our version only used as a fallback. If the clang-format-path setting is not set, the path to the executable will be queried with which on launch. The only hard-coded path involved would be if the user specified one, which I think should always take precedence.

Does it fallback to the shipped clang-format if it's not found on the path?

Just to make sure I understand your comment correctly; I had assumed you meant if not found on a user-specified path. My understanding is that which would not return a path unless the executable was 'found' on that path.

I'm not convinced that falling back to the bundled version if someone has incorrectly configured their path, would be the right thing to do, as it would silently fail to use the setting they provided. IMHO, it would be better to fail. Also, I'm not convinced a new setting to override the behavior makes sense. I think using the version installed on the system should be preferred, and our version only used as a fallback. If the clang-format-path setting is not set, the path to the executable will be queried with which on launch. The only hard-coded path involved would be if the user specified one, which I think should always take precedence.

If they don't have any clang_format_path set, shouldn't it fall back to the bundled one? I think that's what your code does currently. How does the user overwrite the defaults (PATH version) to get the bundled one if they want it?

Does it fallback to the shipped clang-format if it's not found on the path?

Just to make sure I understand your comment correctly; I had assumed you meant if not found on a user-specified path. My understanding is that which would not return a path unless the executable was found on that path.

Yeah, I wasn't talking about an explicitly set clang_format_path, I was talking about the PATH found from "which".

If this is just TypeScript changes can it go into 0.26.3-insiders4?

If this is just TypeScript changes can it go into 0.26.3-insiders4?

Yes. I'll update the changelog.