Update package.json for 0.26.3#4690
Merged
Colengms merged 4 commits intoDec 5, 2019
mastermicrosoft/vscode-cpptools:masterfrom
mimatias/master-26-3microsoft/vscode-cpptools:mimatias/master-26-3Copy head branch name to clipboard
Merged
Update package.json for 0.26.3#4690Colengms merged 4 commits intomastermicrosoft/vscode-cpptools:masterfrom mimatias/master-26-3microsoft/vscode-cpptools:mimatias/master-26-3Copy head branch name to clipboard
Colengms merged 4 commits into
mastermicrosoft/vscode-cpptools:masterfrom
mimatias/master-26-3microsoft/vscode-cpptools:mimatias/master-26-3Copy head branch name to clipboard
Conversation
michelleangela
commented
Dec 3, 2019
Contributor
- updated version
- updated links for binaries
Colengms
reviewed
Dec 3, 2019
Colengms
left a comment
Contributor
There was a problem hiding this comment.
Why are the linkid's changed in master but not release? Did wrong (not updated) links go out in release? Until master diverges significantly enough to require new offline binaries for tests to pass, shouldn't master be using the same linkid's as release?
Contributor
Author
These new linkids are for the next release but point to the same binaries are the current release. The current release has the correct linkids. |
Colengms
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.