Merged
Update locale id lookup to match approach used by vscode-nls#4474
Conversation
michelleangela
approved these changes
Oct 21, 2019
sean-mcmanus
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approach used by vscode-nls to determine the currently locale/language is here: https://github.com/microsoft/vscode-nls/blob/fe0fbef1c9825767c40d70d8d7817c31b31cd3ab/src/main.ts#L147
This change more closely matches the approach it uses.
Also updated package.json to avoid duplicate call to prepublish.js when building for production.