Add validation for paths from env variable#4100
Merged
michelleangela merged 2 commits intoAug 19, 2019
mastermicrosoft/vscode-cpptools:masterfrom
mimatias/path-validatemicrosoft/vscode-cpptools:mimatias/path-validateCopy head branch name to clipboard
Merged
Add validation for paths from env variable#4100michelleangela merged 2 commits intomastermicrosoft/vscode-cpptools:masterfrom mimatias/path-validatemicrosoft/vscode-cpptools:mimatias/path-validateCopy head branch name to clipboard
michelleangela merged 2 commits into
mastermicrosoft/vscode-cpptools:masterfrom
mimatias/path-validatemicrosoft/vscode-cpptools:mimatias/path-validateCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3912
For .json file validation
Only env variables that are used in the current active configuration are validated.
For config UI validation
Any invalid path from env variables will show up as full resolved path in the error message.