Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add support for x86 architecture#4005

Merged
Jasdriel merged 13 commits into
mastermicrosoft/vscode-cpptools:masterfrom
joreyesp/supportArchitecturemicrosoft/vscode-cpptools:joreyesp/supportArchitectureCopy head branch name to clipboard
Aug 8, 2019
Merged

Add support for x86 architecture#4005
Jasdriel merged 13 commits into
mastermicrosoft/vscode-cpptools:masterfrom
joreyesp/supportArchitecturemicrosoft/vscode-cpptools:joreyesp/supportArchitectureCopy head branch name to clipboard

Conversation

@Jasdriel

Copy link
Copy Markdown
Contributor

I add the json files and also add the options for choose the 32 bit for each compiler (msvc, clang, gcc), If you could guide more if I am missing something or if some logic also needs to be changed

Comment thread Extension/bin/msvc.32.darwing.msvc.json
Comment thread Extension/c_cpp_properties.schema.json
Comment thread Extension/ui/settings.html Outdated
Comment thread Extension/ui/settings.html Outdated
@Jasdriel Jasdriel marked this pull request as ready for review July 31, 2019 22:42
Comment thread Extension/ui/settings.html Outdated
@bobbrow bobbrow added this to the August 2019 milestone Aug 7, 2019
Comment thread Extension/c_cpp_properties.schema.json
Comment thread Extension/c_cpp_properties.schema.json Outdated
},
"intelliSenseMode": {
"description": "If set, it overrides the default mode used by the IntelliSense engine. Windows defaults to msvc-x64, Linux defaults to gcc-x64, and Mac defaults to clang-x64.",
"description": "The IntelliSense mode to use that maps to an architecture-specific variant of MSVC, gcc, or Clang. If not set or if set to ${default}, the extension will choose the default for that platform. Windows defaults to msvc-x64, Linux defaults to gcc-x64, and macOS defaults to clang-x64. Select a specific IntelliSense mode to override the ${default} mode.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the last line. Select a specific IntelliSense mode to override the ${default} mode.

@michelleangela michelleangela self-requested a review August 7, 2019 21:39
@Jasdriel Jasdriel merged commit 41893b0 into master Aug 8, 2019
@Jasdriel Jasdriel deleted the joreyesp/supportArchitecture branch August 8, 2019 17:07
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.