Update examples in colorization.md to color entity.name.type instead of entity.name.type.class#3973
Merged
Colengms merged 3 commits intoJul 25, 2019
mastermicrosoft/vscode-cpptools:masterfrom
coleng/updateColorizationDoc2microsoft/vscode-cpptools:coleng/updateColorizationDoc2Copy head branch name to clipboard
Merged
Update examples in colorization.md to color entity.name.type instead of entity.name.type.class#3973Colengms merged 3 commits intomastermicrosoft/vscode-cpptools:masterfrom coleng/updateColorizationDoc2microsoft/vscode-cpptools:coleng/updateColorizationDoc2Copy head branch name to clipboard
Colengms merged 3 commits into
mastermicrosoft/vscode-cpptools:masterfrom
coleng/updateColorizationDoc2microsoft/vscode-cpptools:coleng/updateColorizationDoc2Copy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change restores the scope associated with the Type token to entity.name.type, in documentation (colorization.md) only.
This is essentially a mitagation of differences between TextMate and IntelliSense behavior. TextMate uses different tokens where a type is declared vs used, and has granular class types (unions, structs, etc), whereas IntelliSense considers declation, use, and all types, as the same Type token type. If we guide the user to color entity.name.type.class, in other languages they will see it only where classes are declared and not where they are used, whereas in C/C++ it will be used for all cases. Coloring entity.name.type will apply the color to all types in other languages, which is consistent with what they will see in C/C++.