Add more linting.#3847
Add more linting.#3847sean-mcmanus merged 7 commits intomastermicrosoft/vscode-cpptools:masterfrom seanmcm/addMoreLintingmicrosoft/vscode-cpptools:seanmcm/addMoreLintingCopy head branch name to clipboard
Conversation
|
@sean-mcmanus Why are you disabling a lot of items in tslint when you say you are "Adding more linting"? I think you need to explain more about why certain things are being turned off. Like |
WardenGnaw
left a comment
There was a problem hiding this comment.
There is a lot of lint changes that are arguably should be enabled.
Yeah, but we were failing so I disabled them for now, but they're listed as "false" so they're easier to discover. If there are any in particular, you think we should try to fix now, I could investigate more. |
Did I disable existing linting errors? I don't see any. The intention was to explicitly add the things that are disabled so we could revisit them later. |
I think I fixed those now. |
I added the TODO's to our internal docs and removed the "false" rules. |
| "prefer-while": true, | ||
| "promise-must-complete": true, | ||
| "semicolon": true, | ||
| "space-within-parens": true, |
There was a problem hiding this comment.
Not sure if this is doing anything:
https://palantir.github.io/tslint/rules/space-within-parens/
There was a problem hiding this comment.
No, this is correct. The docs are wrong. Or...it's correct with my version of TS Lint, which enforces the 0 space rule when "true" is used and doesn't accept a number like the docs say.
I hit a bug in my FindAllReferences branch that would have been caught by more linting. Most of the changes are whitespace, or other trivial/quick changes.