Avoid applying edits to cached colorization tokens until needed#3793
Merged
Colengms merged 4 commits intoJun 18, 2019
mastermicrosoft/vscode-cpptools:masterfrom
coleng/delay_update_editsmicrosoft/vscode-cpptools:coleng/delay_update_editsCopy head branch name to clipboard
Merged
Avoid applying edits to cached colorization tokens until needed#3793Colengms merged 4 commits intomastermicrosoft/vscode-cpptools:masterfrom coleng/delay_update_editsmicrosoft/vscode-cpptools:coleng/delay_update_editsCopy head branch name to clipboard
Colengms merged 4 commits into
mastermicrosoft/vscode-cpptools:masterfrom
coleng/delay_update_editsmicrosoft/vscode-cpptools:coleng/delay_update_editsCopy head branch name to clipboard
Conversation
sean-mcmanus
approved these changes
Jun 17, 2019
Contributor
Author
|
This will address #3780 for themes with background colors equal to the editor background color. Selection highlighting will still fail for background colors that differs from the editor background color. |
Contributor
Author
|
This may improve #3781 . There is definitely overhead involved for various reasons. But, this change may improve performance when editing as it avoids adjusted cached token ranges while editing, deferring that work until/unless cache tokens need to be reapplied (i.e. change editor visibility). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid applying edits to cached tokens unless/until they need to be reapplied. (Similar fix applied to native side)
Avoid setting background color of decoration if same as editor background, to avoid selection highlighting issue.
Ensure editVersion is always increment per onDidChangeTextDocument, to ensure in sync with native side. (Has corresponding change on native side)