Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Vcpkg integration#3791

Merged
bobbrow merged 66 commits into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
grdowns:vcpkg-integrationCopy head branch name to clipboard
Aug 8, 2019
Merged

Vcpkg integration#3791
bobbrow merged 66 commits into
microsoft:mastermicrosoft/vscode-cpptools:masterfrom
grdowns:vcpkg-integrationCopy head branch name to clipboard

Conversation

@grdowns

@grdowns grdowns commented Jun 17, 2019

Copy link
Copy Markdown
Contributor
  • Adds VcpkgClipboardInstallSuggested and VcpkgOnlineHelpSuggested commands/code actions
    • VcpkgClipboardInstallSuggested
      • From command palette: globs up all missing #include errors and matches each to an include in vcpkg and copies a vcpkg install line to the user's clipboard. E.g. vcpkg install boost-hana:x64-linux
      • From code action context menu: Matches the current line to an include in vcpkg and copies a vcpkg install line to the user's clipboard
    • VcpkgOnlineHelpSuggested
      • Sends the user to aka.ms/vcpkg
      • Function does not differ between command palette and code action context menu

The C++ side of the PR will be coming soon. This PR requires these changes in the C++ side:

  • Add a source and code to missing #include diagnostics
  • Copy over VCPkgHeaderDatabase.zip using CMake's install function

Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/package.json
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/package.nls.json Outdated
@sean-mcmanus sean-mcmanus added this to the July 2019 milestone Jun 18, 2019
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts
Comment thread Extension/src/LanguageServer/extension.ts
Comment thread Extension/src/LanguageServer/extension.ts
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
@grdowns

grdowns commented Aug 5, 2019

Copy link
Copy Markdown
Contributor Author

As a heads up, I'm dealing with the command title localization right now. VS Code has a vscode-nls localization module

Comment thread Extension/src/LanguageServer/extension.ts Outdated
Comment thread Extension/src/LanguageServer/extension.ts Outdated
@grdowns

grdowns commented Aug 7, 2019

Copy link
Copy Markdown
Contributor Author

TS2741: Property 'getCompilerPath' is missing in type 'DefaultClient' but required in type 'Client'

@grdowns

grdowns commented Aug 7, 2019

Copy link
Copy Markdown
Contributor Author

I'm handling it -- one moment

@bobbrow bobbrow merged commit ba2da8d into microsoft:master Aug 8, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.